voxpupuli / puppet_metadata

The gem intends to provide an abstraction over Puppet's metadata.json file. Its API allow easy iteration over its illogical data structures.
Apache License 2.0
3 stars 13 forks source link

Update documentation to reflect OSes that don't run acceptance tests #106

Open bschonec opened 1 year ago

bschonec commented 1 year ago

Gentoo is not supported by metadata/beaker.

SLES and RHEL do not run acceptance tests because they both require valid licenses in order to install required packages.

This behavior is not documented (at least not that I've found) and for someone unfamiliar with the Voxpupuli workflow, it's difficult to understand why SLES/RHEL don't run tests without a deep dive into the source code.

I recommend updating the README.md to explain this behavior to those unfamiliar. One advantage would be to make it easier for non-developers to contribute to Voxpupuli in general.

ekohl commented 1 year ago

Technically it's this bit that determines whether acceptance tests are supported: https://github.com/voxpupuli/puppet_metadata/blob/bb8ecacc63f22d9dea3a9b61e8e83338b26eb423/lib/puppet_metadata/beaker.rb#L85-L89

Edit: when linking to a line on GitHub you should get the absolute URL which includes the commit blob. You can press y to change the URL. This is because line numbers change over time.

Gentoo is not supported by metadata/beaker.

ekohl commented 1 year ago

I've opened a PR for a new blog post: https://github.com/voxpupuli/voxpupuli.github.io/pull/328