MVC Rework - Githubissues

voxpupuli / puppet_webhook

Sinatra-based application that triggers puppet-related commands from VCS Webhook calls

Apache License 2.0

13 stars 7 forks source link

MVC Rework #83

Closed dhollinger closed 5 years ago

dhollinger commented 5 years ago

Rework the application into a Model, View, Controller style framework without changing user-facing functionality.

Benefits:

Cleaner, easier to follow code structure
More modular for adding functionality with less effort
Be able to manage user data (authentication) within the model

Drawbacks:

Unused components (Probably won't benefit from views)
Larger Directory Structure
More complicated packaging process (no gemspec file)

coveralls commented 5 years ago

Coverage decreased (-2.3%) to 52.189% when pulling 1264129c8df66c41ed162a9d41d2aa0547a5ef2a on dhollinger:mvc_rework into b089f4ea1b156ccf13b9e6d143865c467b58030e on voxpupuli:master.