search

voxpupuli / pypuppetdb

Python library for working with the PuppetDB API
Apache License 2.0
92 stars 70 forks source link

use unittest.mock instead of mock #227

Closed pgajdos closed 2 years ago

pgajdos commented 2 years ago

Could you please consider to utilize unittest.mock instead of mock, as a fallback at least?

gdubicki commented 2 years ago

Hi @pgajdos! Why would we want that?

pgajdos commented 2 years ago

I think it could be considered nice to drop dependencies which are not required.

pgajdos commented 2 years ago

Background: https://trello.com/c/S6eADbii/64-remove-python-mock

gdubicki commented 2 years ago

Oh, then sure. Can you create PR for this as you already investigated the subject?

pgajdos commented 2 years ago

Done: #228

gdubicki commented 2 years ago

Thanks again @pgajdos! Released in v2.5.2.