voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

Introduce RuboCop and fix various cops #146

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

This takes https://github.com/voxpupuli/rspec-puppet-facts/pull/144 and fixes various cops, instead of building a large TODO file. There still are some TODOs, but it helps.

@bastelfreak let me know if you prefer this and if I should submit some as separate PRs.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 :warning:

Comparison is base (ae75c7a) 95.06% compared to head (247d76a) 94.93%.

:exclamation: Current head 247d76a differs from pull request most recent head 8b8773b. Consider uploading reports for the commit 8b8773b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ========================================== - Coverage 95.06% 94.93% -0.13% ========================================== Files 2 2 Lines 162 158 -4 ========================================== - Hits 154 150 -4 Misses 8 8 ``` | [Impacted Files](https://codecov.io/gh/voxpupuli/rspec-puppet-facts/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/rspec-puppet-facts.rb](https://codecov.io/gh/voxpupuli/rspec-puppet-facts/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL3JzcGVjLXB1cHBldC1mYWN0cy5yYg==) | `98.03% <100.00%> (-0.05%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.