search

voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

Drop Ruby 2.4/2.5/2.6 support #149

Closed bastelfreak closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0921dff) 94.93% compared to head (810635c) 94.93%.

:exclamation: Current head 810635c differs from pull request most recent head 0857fbf. Consider uploading reports for the commit 0857fbf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #149 +/- ## ======================================= Coverage 94.93% 94.93% ======================================= Files 2 2 Lines 158 158 ======================================= Hits 150 150 Misses 8 8 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alexjfisher commented 1 year ago

Echoing https://github.com/voxpupuli/puppet-blacksmith/pull/109#issuecomment-1474171820 I'd only drop 2.4 for now as I don't think you're helping anyone by being overly aggressive without tangible benefits.

Puppet 6 (with Ruby 2.5) has only just gone EOL. IMO it's not helping people upgrading from 6 to 7 if we drop ruby 2.5 support in all the core testing gems.

bastelfreak commented 1 year ago

It might not help them, but it doesn't hurt them. The gem works fine with Ruby 2.5/Puppet 6 and with Ruby 2.7/Puppet 7. I think it even works already with Puppet 8. So why should we keep support for a ruby version that left normal maintenance mode at 2020-04-01 and does not even get security updates since 2021-04-05?

And as mentioned in the blacksmith PR, we need to bump the minimal Ruby version, at least for acceptance tests, to 2.7 anyways with the next major beaker release.

alexjfisher commented 1 year ago

Will this limit its inclusion with the PDK?

bastelfreak commented 1 year ago

I don't think so. Why should it limit this? pdk-tempaltes just needs to pin to the current major version of rspec-puppet-facts. Which it already does: https://github.com/puppetlabs/pdk-templates/blob/2.7.3/config_defaults.yml#L587-L588

alexjfisher commented 1 year ago

But it will then miss out on the legacy facts stuff we've started working on, and I think that would be a shame and hurt users.

bastelfreak commented 1 year ago

We don't need to merge this now, we can first merge https://github.com/voxpupuli/rspec-puppet-facts/pull/143 and do a final minor release.

alexjfisher commented 1 year ago

Until supporting ruby 2.5 is actually holding us back (limiting what version of rubocop we can use, or some new ruby feature we would like), I'm strongly in favour of not advancing past the versions of ruby that ship with the PDK.

ekohl commented 1 year ago

I agree with @alexjfisher that - besides beaker - dropping Ruby 2.5 is a tad too aggressive for now.

alexjfisher commented 1 year ago

Also FWIW puppetserver 7's jruby is only ruby 2.6 compatible.