voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

Use Hash.to_h to construct a new hash #150

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

Also declares stringify_keys as a private API method.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8d9370c) 94.93% compared to head (5e301c3) 94.93%.

:exclamation: Current head 5e301c3 differs from pull request most recent head 59fb9bb. Consider uploading reports for the commit 59fb9bb to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #150 +/- ## ======================================= Coverage 94.93% 94.93% ======================================= Files 2 2 Lines 158 158 ======================================= Hits 150 150 Misses 8 8 ``` | [Impacted Files](https://app.codecov.io/gh/voxpupuli/rspec-puppet-facts/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/rspec-puppet-facts.rb](https://app.codecov.io/gh/voxpupuli/rspec-puppet-facts/pull/150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL3JzcGVjLXB1cHBldC1mYWN0cy5yYg==) | `98.03% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ekohl commented 1 year ago

Interesting that this behavior is different on Ruby 2.4 & 2.5. I think you finally have a good excuse to drop older versions because I do think this newer version is easier to read.

bastelfreak commented 1 year ago

press the button on https://github.com/voxpupuli/rspec-puppet-facts/pull/149 :)