search

voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

voxpupuli-rubocop: Pin to patch version #161

Closed bastelfreak closed 5 months ago

bastelfreak commented 5 months ago

We do this on all other projects as well. New minor version might pull in new rubocop versions. To ensure that we test those in a PR, we pin to the patch release. dependabot will inform us about updates.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eb35a8d) 95.20% compared to head (10b4ad5) 95.20%.

:exclamation: Current head 10b4ad5 differs from pull request most recent head 200cbb7. Consider uploading reports for the commit 200cbb7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #161 +/- ## ======================================= Coverage 95.20% 95.20% ======================================= Files 2 2 Lines 167 167 ======================================= Hits 159 159 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zilchms commented 5 months ago

Seems we are one bundle exec short. "Run the puppet_versions:update task to update it and commit the changes." Otherwise LGTM