search

voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

Release 3.0.0 #166

Closed bastelfreak closed 3 months ago

bastelfreak commented 4 months ago

Waiting a bit for @ekohl in case he want's other breaking changes. CC: @jordanbreen28

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.34%. Comparing base (f20625d) to head (c61c713).

Files Patch % Lines
lib/rspec-puppet-facts/version.rb 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ======================================= Coverage 95.34% 95.34% ======================================= Files 2 2 Lines 172 172 ======================================= Hits 164 164 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bastelfreak commented 3 months ago

I also agree that it's too early to flip to strings. Releasing the current changes fixes some bugs, but if the rollout requires the change to strings it's just a too big change.

A deprecation warning is a good idea but I've no idea how/where to properly implement this.

bastelfreak commented 3 months ago

I added a deprecation notice to the CHANGELOG.md