Closed bastelfreak closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.80%. Comparing base (
09cb9e9
) to head (3fdbb05
). Report is 9 commits behind head on master.:exclamation: Current head 3fdbb05 differs from pull request most recent head f5fcdb5
Please upload reports for the commit f5fcdb5 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'd be tempted to remove all symbol keys from FacterDB and then do the .to_sym here in rspec-puppet-facts if requested. Any thoughts on that?
I considered that, but that would be another breaking change. I think with the current implementation it allows us to release it as an enhancement and then we can use the new rspec-puppet-facts + FacterDB version. Afterwards I would like to update FacterDB as you mentioned and also switch to strings by default in rspec-puppet-facts.
Basically:
Did you intend to squash all your changes in a single commit?
This contains #176