voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

work with symbolized strings #175

Closed bastelfreak closed 1 month ago

bastelfreak commented 1 month ago

This contains #176

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.80%. Comparing base (09cb9e9) to head (3fdbb05). Report is 9 commits behind head on master.

:exclamation: Current head 3fdbb05 differs from pull request most recent head f5fcdb5

Please upload reports for the commit f5fcdb5 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## ========================================== + Coverage 95.34% 95.80% +0.45% ========================================== Files 2 2 Lines 172 167 -5 ========================================== - Hits 164 160 -4 + Misses 8 7 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bastelfreak commented 1 month ago

I'd be tempted to remove all symbol keys from FacterDB and then do the .to_sym here in rspec-puppet-facts if requested. Any thoughts on that?

I considered that, but that would be another breaking change. I think with the current implementation it allows us to release it as an enhancement and then we can use the new rspec-puppet-facts + FacterDB version. Afterwards I would like to update FacterDB as you mentioned and also switch to strings by default in rspec-puppet-facts.

Basically:

ekohl commented 1 month ago

Did you intend to squash all your changes in a single commit?