search

voxpupuli / rspec-puppet-facts

Simplify your unit tests by looping on every supported Operating System and populating facts.
Apache License 2.0
61 stars 53 forks source link

Use more native rspec matchers in tests #179

Closed ekohl closed 3 months ago

ekohl commented 3 months ago

By using be_a and contain_exactly the tests are more expressive and rspec is better able to tell you what doesn't match. It also removes the (now redundant) size checks on results, given contain_exactly already gives that guarantee.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.03%. Comparing base (cfa4977) to head (907fdf9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ======================================= Coverage 95.03% 95.03% ======================================= Files 2 2 Lines 161 161 ======================================= Hits 153 153 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.