Open sahaqaa opened 12 months ago
@sahaqaa I will look into this. The issues I do see with this request at first glance are:
As for the Response field, I will look into what's going on there. It should at least send a response stating what happened with the request. But a full tracking of state would require a separate service to report to.
Hello, we've previously used version "2.0.1", now we are upgrading to "2.2.0". Full current config:
When testing we've seen next output in logs of Bitbucket server:
and in logs of systemd service:
What seems to be not right:
I believe in case webhook-go was able to process/deploy without errors - it may be better to send different "Response" and different "State".
When i change "verbose: true" response in Bitbucket server logs:
It would be better if, for example, "State" could be "applied" and "Response" could contain something like "Environment testing_webhook_upgrade is now at 80ba8d60a3545076534ef551f959a8c551c259f0"
With " verbose: false" and with "verbose: true" output is the same:
I.e. i can see that first webhook-go sends response to Bitbucket server and only after that Worker picking up "job", but in logs there are no indications if Job succeded or not.
It would be good if in case when webhook-go was able to apply/deploy code -> there would be second entry with clear indication that code was applied/deployed successfully