voyagegroup / ingred-ui

https://ingred-ui.netlify.app
MIT License
53 stars 10 forks source link

🐛 MultipleFilter 日本語指定時に表示される不要なデフォルト値を削除(conditionTitle) #1653

Closed trailstem closed 1 month ago

trailstem commented 1 month ago

1646 修正時の考慮漏れ

Check List (If️ you added new component in this PR)

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 87f9128760bfce573c3ae1dfc656cbf5930c1ee3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------- | ----- | | ingred-ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for ingred-ui ready!

Name Link
Latest commit 87f9128760bfce573c3ae1dfc656cbf5930c1ee3
Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/669dc5f3a6940700081ed204
Deploy Preview https://deploy-preview-1653--ingred-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

trailstem commented 1 month ago

storybookで確認する際、日本語設定で確認することができないのでコードベースでレビューいただきたいですmm

noronaoki commented 1 month ago

@trailstem LGTM