search

voyagegroup / popuko

A helpful operation bot for GitHub. This helps to assign a reviewer, to merge a pull request, and to notify an unmergeable pull request with a comment as a command interactively.
Other
76 stars 10 forks source link

Drop building with Go's master from TravisCI #272

Closed tetsuharuohzeki closed 4 years ago

tetsuharuohzeki commented 5 years ago

When I added this option, then we develop this project aggressively, and Go toolchain also changes aggressively by their version up.

However, the situation is changed.

  1. This project is almost maintaince mode.
    • We would not have any strong motivation to check the project built with latest nightly Go toolchain.
  2. Go toolchain looks mild about upgrading breaking changes.

By above things, I think it will not be a problem if we drop to build with Go toolchain which is develop branch.

tetsuharuohzeki commented 5 years ago

r? @nekoya

nekoya commented 4 years ago

@popuko r+

popuko commented 4 years ago

:pushpin: Commit 0e4cd290d6ebcbc8aedfe5dbe54dc45b912e19b9 has been approved by nekoya

popuko commented 4 years ago

:postbox: This pull request is queued. Please await the time.

popuko commented 4 years ago

:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

popuko commented 4 years ago

:lock: Merge conflict

tetsuharuohzeki commented 4 years ago

r? @nekoya

I resolved the conflict.

nekoya commented 4 years ago

@popuko r+

popuko commented 4 years ago

:pushpin: Commit a6daec5e6dda443e64256655f25a98d335503eb8 has been approved by nekoya

popuko commented 4 years ago

:hourglass: a6daec5e6dda443e64256655f25a98d335503eb8 has been merged into the auto branch 8eee3339b3fdfd7d023b5b40d812bb6e8938953c

popuko commented 4 years ago

:tada: The result of what tried to merge this pull request is success.