Support the default branch set by GitHub config

voyagegroup / popuko

A helpful operation bot for GitHub. This helps to assign a reviewer, to merge a pull request, and to notify an unmergeable pull request with a comment as a command interactively.

Other

76 stars 10 forks source link

Support the default branch set by GitHub config #275

Closed tetsuharuohzeki closed 4 years ago

tetsuharuohzeki commented 4 years ago

Fix https://github.com/voyagegroup/popuko/issues/196
- GitHub will change the default branch name for a new repository. So we need to fix this bug.
By the document for GitHub webhook, we can get the branch name from a webhook event. But I cannot trust their document and their examples are sometimes different actual json payload. Thus I added a fallback path as the workaround.
- In the worst case, this bot will increase 1 API request per events.

tetsuharuohzeki commented 4 years ago

r? @nekoya

@nekoya @mitsukavg @yamachu

Could you try this patch?

nekoya commented 4 years ago

@popuko r+

popuko commented 4 years ago

:pushpin: Commit ff136577e92a04e5d28b20cc647c15f0e641f3d7 has been approved by nekoya

popuko commented 4 years ago

:hourglass: ff136577e92a04e5d28b20cc647c15f0e641f3d7 has been merged into the auto branch 1e983b73375b37c53f83560c823ac566e7c4bc5b

popuko commented 4 years ago

:tada: The result of what tried to merge this pull request is success.

The Travis CI build passed