voyagermesh / voyager

🚀 Secure L7/L4 (HAProxy) Ingress Controller for Kubernetes
https://voyagermesh.com
Apache License 2.0
1.35k stars 134 forks source link

Voyager doesn't work with cloud = minikube and type = HostPort #272

Closed joshk0 closed 7 years ago

joshk0 commented 7 years ago

I'm trying to use voyager 3.0 on kubernetes 1.5.1 (minikube) with voyager.ingress.appscode.com (extended ingress) in HostPort mode and cloud = minikube.

I find that voyager is able to detect the creation of the TPR, but it does not create the service, configmap, or deployment for the ingress.

Before I go sourcediving, is this at all supported or is cloud = minikube not recommended for any use?

My use case is for people developing against Voyager without needing to push to AWS.

cc: @julianvmodesto

sadlil commented 7 years ago

@joshk0 For development purpose voyager supports minikube. If you could provide operator logs we can take a look on this.

joshk0 commented 7 years ago

The problem was that lbc.Create() was returning an error, but nothing was printing that final error since callers call lbc.Create() without checking for error output.

There were two issues:

I worked around it just now by removing the check in createHostPortPods(). I will probably add a silly nodeSelector, something like beta.kubernetes.io/os=linux

joshk0 commented 7 years ago

Feel free to split this bug into smaller ones for action.