search

voyageur / openglide

Git mirror of openglide CVS (http://openglide.sourceforge.net/)
GNU Lesser General Public License v2.1
48 stars 17 forks source link

fix grTexDownloadMipMapLevelPartial #10

Closed dpethes closed 6 years ago

dpethes commented 6 years ago

Fixes invalid grTexDownloadMipMapLevelPartial behavior - it should only read and replace data of the size specified by start-end rows. Previously the start-end range was ignored and data block of the size of the given mip level was copied to internal memory. This works only if start is 0, the data block is large enough and the rest of the texture data is unchanged. Otherwise it causes texture corruption or crashes due to invalid reads.

I don't know if Glidos uses this function or not. If it does, it would need a different fix, but my guess is that it doesn't - somebody would likely already notice that it's broken.

voyageur commented 6 years ago

Wow, I did not expect any (new) activity on this repository! Thanks, I will push it asap (looks OK from what I can see, but you certainly know much more about this code than I do)

dpethes commented 6 years ago

Cool, thanks! I'm doing some retro glide programming and this looks like the only "live" openglide repository :)

voyageur commented 6 years ago

I think it is, at least it was when I was looking for a proper repo where I could land some files for easier dosbox integration :)