search

voyageur / openglide

Git mirror of openglide CVS (http://openglide.sourceforge.net/)
GNU Lesser General Public License v2.1
48 stars 17 forks source link

Replace sizeof() checks with cstdint include #16

Closed linkmauve closed 4 years ago

linkmauve commented 4 years ago

This makes the types consistent on all platforms.

Running ./configure is now faster by more than 1s (5.0s → 3.8s on my computer).

In the future, it might be nice to outright replace them like in https://github.com/joncampbell123/dosbox-x/pull/1889

voyageur commented 4 years ago

Yes, looking at the basic data types section in sdk2_3dfx.h, it is tempting to go to next step and just use the real types!

linkmauve commented 4 years ago

My worry is that games which rely on these types would fail to build after the renaming, while keeping these aliases avoids the issue altogether. I didn’t have this issue in dosbox-x because it doesn’t expose its API to users.

voyageur commented 4 years ago

True, that may trigger a chain of sed commands (and maybe mistakes) in different projects. At least, these are just the default ones (typedef'ed)