search

voyageur / openglide

Git mirror of openglide CVS (http://openglide.sourceforge.net/)
GNU Lesser General Public License v2.1
48 stars 17 forks source link

Fix warnings #18

Closed linkmauve closed 4 years ago

linkmauve commented 4 years ago

Once again this PR is better read commit per commit, most of them are quite simple.

voyageur commented 4 years ago

Hi, just commenting to say I saw your PR series! I hope to find some time soon to at least quickly review them and merge (so others can enjoy)

linkmauve commented 4 years ago

Fyi, this fixes #13.

voyageur commented 4 years ago

I just pushed a50467025dc95edb8cef6af3b788eb6a44b897f5 to only have system glext.h, let's see if that breaks something (I just made a compile run for now)

linkmauve commented 4 years ago

Your commit did break the mingw-w64 build, #include <GL/glext.h> in Glextensions.h fixes it, but it might not be the proper fix.

voyageur commented 4 years ago

Ack, how about 1708246bf74156fe9012f1019648b3ac0ca95b5d ? This restore glext.h inclusion though switching to system one and keeping the GL_GLEXT_VERSION guard (I need to add a mingw-w64 toolchain locally so I do not keep asking "did I fix it yet?")