voyageur / openglide

Git mirror of openglide CVS (http://openglide.sourceforge.net/)
GNU Lesser General Public License v2.1
48 stars 17 forks source link

platform/dosbox/dosbox_glide.diff no longer applies to DOSBox git checkout #9

Closed Sophira closed 6 years ago

Sophira commented 6 years ago

A change in DOSBox's configure.ac file on 10th October 2017 ( https://sourceforge.net/p/dosbox/code-0/4056/ ) means that the platform/dosbox/dosbox_glide.diff file in this project no longer cleanly applies; the hunk that changes the LIBS line for Cygwin/mingw32 gets rejected.

At a glance, the fix appears to be fairly simple - just add the "-lshlwapi" flag back - but I don't know enough about the patch to know whether this will work or not, and I don't have the correct build environment for it.

voyageur commented 6 years ago

Thanks for the report, I will update the patch (I have a few demos lying around my dosbox directory so can test). I will also copy the original patch for people still using 0.74

Sophira commented 6 years ago

By the way, thank you for updating the Gentoo repository at the same time! This actually came about because I was using the live ebuild on Gentoo, and I had opened a bug for it there too.

I've marked it RESOLVED FIXED now, but it seems rude to add others to CC, so wanted to make sure you saw my gratitude somehow. :D Thank you!

voyageur commented 6 years ago

No problem, the live Gentoo ebuild is the main reason for that patch being around, so better to have both working fine :)