voyanttools / Voyant

GNU General Public License v3.0
73 stars 6 forks source link

Update localisation (FR and beyond) #62

Open aurelberra opened 1 year ago

aurelberra commented 1 year ago

Hi @ajmacdonald. Thanks again for the great work you're doing on Voyant Tools!

I was in charge of the French localisation and discussed various issues with Stéfan over the years. The locales were first contributed via a spreadsheet which seems to be the (initial?) source of the current TSV file I see in this repo.

My first and main question is: How do you plan to update, i.e. correct and improve, the localisation?

As for the French version, I had noticed a few translations to add. I just went through a lot of recent commits, browsed the JS files, and tried out newer or less frequently used tools to see if my list had to be expanded. Here is the result:

I am happy to contribute what I can as PRs here on GitHub. Please let me know what you think and how I can help!

ajmacdonald commented 1 year ago

Hi Aurélien, thank you reaching out about this, and for your previous localization work. There is a Google spreadsheet that is used as the translations source and which gets exported to that TSV file. Can you please email me at voyanttools@gmail and I'll send you the link to it?

aurelberra commented 1 year ago

Done!

aurelberra commented 1 year ago

Thanks for sending me the new link! I updated the following elements in the shared spreadsheet:

So that you don't have to compare the lists, here are my remarks from yesterday which are still valid:

Have a nice day!

ajmacdonald commented 1 year ago

Thanks again. I will incorporate your changes into the next release.

Regarding your list of outstanding issues: yes I need to move the hard-coded text values into the spreadsheet. I'm not sure when I'll get to that.

aurelberra commented 1 year ago

Great. Thanks!

ajmacdonald commented 1 year ago

https://github.com/voyanttools/Voyant/commit/b5fc945e656470dd49b4093e98c1e030775074d9