search

voydz / souyuz

Fastlane build plugin for building Xamarin.iOS and Xamarin.Android applications
MIT License
37 stars 10 forks source link

Bugfix/if signing details provided no need to sign with default keypass #40

Closed inikityuk closed 2 years ago

inikityuk commented 2 years ago

When building Xamarin.Android project with: keystore_path keystore_alias keystore_password

provided, "SignAndroidPackage" target added automatically, which causing VisualStudio to build app, than sign with default Xamarin keystore, then "apksign_and_zipalign" sign it again.

This fix checking: if keystore details are provided -> it will replace "SignAndroidPackage" with "Package" to generate apk, then "apksign_and_zipalign" sign apk with desired credentials.

if keystore details are NOT provided: "SignAndroidPackage" with be used to sign apk with Xamarin default credentials and "NO" "apksign_and_zipalign" will be called.

NOTE: sorry for chaining PRs

inikityuk commented 2 years ago

Closing this one for now, will create PR with all changes in a day or two for Android and iOS