voydz / souyuz

Fastlane build plugin for building Xamarin.iOS and Xamarin.Android applications
MIT License
37 stars 10 forks source link

Added keystore password prompt #8

Closed johannesberdin closed 7 years ago

johannesberdin commented 7 years ago

Adds a prompt when the Android keystore password is not set in config - for obvious reasons.

voydz commented 7 years ago

Hey @johannesberdin, thanks for your work.

What would happen if I have no intent to sign an APK? (keystore env vars being empty, see https://github.com/voydz/souyuz/blob/master/lib/souyuz/runner.rb#L16) Could you please verify that those checks are respected?

Thank you in advance. :)

johannesberdin commented 7 years ago

You are right, the prompt only makes sense when keystore alias and path are configured.