search

vpenades / SharpGLTF

glTF reader and writer for .NET Standard
MIT License
454 stars 72 forks source link

Ensure that vertex fields don't get trimmed #210

Closed ds5678 closed 6 months ago

ds5678 commented 6 months ago

This pull request addresses half of #209 and has a small optimization for _GetMemoryAccessInfo.

ds5678 commented 6 months ago

I see this breaks custom vertices. I guess that makes this not viable.

vpenades commented 6 months ago

Indeed, this would break custom vertices, so this solution is not an option.

It's a non trivial solution because on one side I have to support down to netstandard2.0 , and on the other I have to support custom vertices and trimming.

For now I am working on a solution that uses attribute decoration to signal that some classes should not be trimmed, I expect to commit it in a few days.

Thaks anyway for trying!

vpenades commented 6 months ago

closing