[BUG] IOR is not preserved when using Scene.ToGltf2() - Githubissues

vpenades / SharpGLTF

glTF reader and writer for .NET Standard

MIT License

482 stars 77 forks source link

[BUG] IOR is not preserved when using Scene.ToGltf2() #246

Closed PassiveModding closed 2 months ago

PassiveModding commented 2 months ago

Describe the bug IOR values are not transferred when running Scene.ToGltf2()

This happens because the value of the field is set in https://github.com/vpenades/SharpGLTF/blob/f5cd805711f76596a77a71de9cba4717e0edd159/src/SharpGLTF.Toolkit/Schema2/MaterialExtensions.cs#L393 happens before extensions are cleared for specific shader styles.

To Reproduce

Use Example1 project.
Set either material's IndexOfRefraction to a non-default value
Run Example1 project
Check output file for IOR extension

please complete the following information:

OS: Windows
SharpGLTF Version 1.0.1

Potential solutions

Include MaterialIOR as a supported extension on PBRMetallicRoughness
Move the assignment to after shaderstyle is set

vpenades commented 2 months ago

thanks, I'll look into it