search

vpenades / SharpGLTF

glTF reader and writer for .NET Standard
MIT License
467 stars 75 forks source link

Make BinarySerialization public? #60

Closed koliyo closed 3 years ago

koliyo commented 4 years ago

The BinarySerialization class has some useful utilities that I would like to be able to use externally, especially BinarySerialization._Identify(stream) to check if stream is binary or ascii.

Now I had to copy the code to be able to call it from external namespace.

vpenades commented 4 years ago

I would really preffer to keep that class internal, because it gives me room for refactoring without breaking any API.

The reading/writing APIs are located in the general reader/writer classes, so it could be possible to expose that functionality there.

Understanding what you want to do would give me a better understanding of what you need.

vpenades commented 3 years ago

I've added this static method: SharpGLTF.IO.ReadContext.IdentifyBinaryContainer