search

vpinball / b2s-backglass

B2S Backglass Server for use with Visual Pinball
Other
48 stars 7 forks source link

Add Backglass toggle #100

Closed stevejones72 closed 6 months ago

stevejones72 commented 6 months ago

https://github.com/vpinball/b2s-backglass/issues/80

stevejones72 commented 6 months ago

Just a note, I updated only the .exe version of the code for now. I'm tempted to work on getting the two codebases into one, but fear that rabbit hole when first looking into a codebase.

jsm174 commented 6 months ago

yeh, its definitely confusing with the two code bases. 😄

When I ported to C++, it's more based on the b2sbackglassserver version (we don't have a registry on cross platform standalone)

JockeJarre commented 6 months ago

I think the merge is more or less finished in the branch (mostly features of the exe brought back to the dll) So yes, please leave the exe behind and let's get only one codebase finally. I will do a last check tomorrow when I am home from vacation.

stevejones72 commented 6 months ago

Thanks JockeJarre, I'll watch for the changes. I have a local version running as an .exe of a quick wrapper that brings in the .dll, that might help with the single codebase. I'm also halfway through building out the .zip container implementation, brings a ~32Mb .directb2s file down to a ~22Mb .directb2sc file size.

stevejones72 commented 6 months ago

Will wait for updates to .dll and will create a PR from that.

stevejones72 commented 6 months ago

Sorry. I closed this PR before I saw your comment, I was waiting to see when your merge of features between the two codebases landed.

JockeJarre commented 6 months ago

No problem... the merge is done, though depending on how your wrapper works we might need to do some more things. That the code can sense how it is started and acts either as dll or exe earlier did.

JockeJarre commented 6 months ago

And your PR was mixing topics "add backglass toggle" could come in separate already now.

stevejones72 commented 6 months ago

On a totally different topic:

I try building vpinball, and when I go to edit a dialog box I get the following:

[cid:3eb6f822-eb7a-420c-833a-bdc438083fa8]

I noticed you changed that file a little while ago, is this something specific with my tooling? I'm using VS2022 professional.

Thanks,

Steve

From: Jarr3 @.> Sent: Tuesday, May 14, 2024 10:23 PM To: vpinball/b2s-backglass @.> Cc: stevejones72 @.>; State change @.> Subject: Re: [vpinball/b2s-backglass] Add Backglass toggle (PR #100)

And your PR was mixing topics "checkbox for backglass" could come in separate already now.

— Reply to this email directly, view it on GitHubhttps://github.com/vpinball/b2s-backglass/pull/100#issuecomment-2111610266, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKZM5RQEYCORQ2K5KXOIHW3ZCLWOTAVCNFSM6AAAAABHIDPIMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRGYYTAMRWGY. You are receiving this because you modified the open/close state.

JockeJarre commented 6 months ago

I must admit I never tried to compile vpx locally... since my changes was minimal I had it all run in my fork, activating the actions. So a couple of pushes later it built correctly on GitHub for me.