search

vpinball / libdmdutil

A cross platform library for performing DMD tasks.
Other
3 stars 8 forks source link

feat: move to big endian for network communications #45

Open nadenislamarre opened 6 months ago

francisdb commented 6 months ago

There's no PR description, what is the reasoning behind the move?

mkalkbrenner commented 6 months ago

There's no PR description, what is the reasoning behind the move?

As commented in the code I didn't care about endianess. The assumption was that dmdserver runs as a service on the same machine as the clients. So endianess should not be an issue. Now @nadenislamarre tries to send data to dmdserver running on a different host.

mkalkbrenner commented 6 months ago

@nadenislamarre uses dmd-play as client. Therefore, the current state of the PR seems to be sufficient. But if the client uses libdmdutil (VPX, PPUC, etc), I assume that big endian should be ensured as well when sending data. Do you agree?

francisdb commented 6 months ago

@mkalkbrenner just wanted to know why, don't want to be involved in decision making as an observer.