Android build fails on macOS

vpinball / libdmdutil

A cross platform library for performing DMD tasks.

Other

3 stars 8 forks source link

Android build fails on macOS #5

Closed YellowLabrador closed 9 months ago

YellowLabrador commented 9 months ago

The platforms/android/arm64-v8a/external.sh script uses nproc which is not a command on macOS. The top level external.sh in vpinball uses this logic

if [[ $(uname) == "Linux" ]]; then
   NUM_PROCS=$(nproc)
elif [[ $(uname) == "Darwin" ]]; then
   NUM_PROCS=$(sysctl -n hw.ncpu)
else
   NUM_PROCS=1
fi

which fixes the issue

jsm174 commented 9 months ago

Great catch! Thank you very much! Fixed in https://github.com/vpinball/libdmdutil/commit/0a7e81f64c32b02596f11c969a07207bea48a8cc