Able to mix different decimals

vpiotr / decimal_for_cpp

Decimal data type for C++

273 stars 68 forks source link

Able to mix different decimals #25

Closed Frafjord closed 8 years ago

Frafjord commented 8 years ago

Added the ability to mix different decimals

vpiotr commented 8 years ago

I'm sorry, but I cannot accept these changes. This library does not perform implicit conversion for a reason - decimal<2> and decimal<4> are treated as different things and should not be auto-converted. It's kind of strong typing. Please use decimal_cast for conversions.

Frafjord commented 8 years ago

the pull request also had an improvement in multdiv and a few more tests.

vpiotr commented 8 years ago

Please create another pull request of changes done on most recent sources, right now it's difficult to see what was changed. In addition, this code has an error (no return statement in one of cases): https://github.com/vpiotr/decimal_for_cpp/pull/25/commits/0fde93e81d236e2cd4ca49456af15ba8fecd69be