search

vpisarev / ficus

The programming language Ficus
Apache License 2.0
72 stars 9 forks source link

Bug fixed of s1d1 in NN Conv #17

Closed zihaomu closed 2 years ago

zihaomu commented 2 years ago

Fix the critical error in s1d1. It can pass all the regression test in opencv_extra. And I will update the s1d1 of FP16 tomorrow.

vpisarev commented 2 years ago

@zihaomu, big thanks for the pull request! I noticed it only this weekend. It will take some time for me to learn the differences between your and my implementation. In my case I do not observe wrong behaviour that you pointed out to, but I will look at it more carefully

zihaomu commented 2 years ago

@zihaomu, big thanks for the pull request! I noticed it only this weekend. It will take some time for me to learn the differences between your and my implementation. In my case I do not observe wrong behaviour that you pointed out to, but I will look at it more carefully

Hi @vpisarev. Actually, the Error occurs when conv+padding. I also didn't find the specific location, so I re-wrote this part.