vplagnol / ExomeDepth

ExomeDepth R package for the detection of copy number variants in exomes and gene panels using high throughput DNA sequencing data.
59 stars 26 forks source link

RangeData objects are deprecated #20

Closed SouzaBB closed 4 years ago

SouzaBB commented 4 years ago

Hello everyone. I'm trying to use ExomeDepth for my CNV analysis but I'm falling on this error:

"RangedData objects are deprecated. Please migrate your code to use
  GRanges or GRangesList objects instead."

I'm using the most recent version of ExomeDepth. The vignette says: "Version 1.1.12: •Updated for GRanges changes." but the error persists.

Does anyone has a fix for this issue?

vplagnol commented 4 years ago

Hey @SouzaBB , thanks for this, I think I just fixed it. Can you run please" devtools::install_github("vplagnol/ExomeDepth") and tell me whether that fixes your issue? I want to make sure I haven't broken other things before pushing to CRAN.

SouzaBB commented 4 years ago

Hi @vplagnol, thanks for replying. Unfortunatelly, still not working! Got the same error.

My command: data(exons.hg19) my.counts <- getBamCounts(bed.frame = exons.hg19, bam.files = "/path/to/my_bam_list", include.chr = F, referenceFasta = "/path/to/hg19.fa"

> sessionInfo()
R version 3.6.0 (2019-04-26)
Platform: x86_64-redhat-linux-gnu (64-bit)
Running under: CentOS Linux 7 (Core)

Matrix products: default
BLAS/LAPACK: /usr/lib64/R/lib/libRblas.so

locale:
 [1] LC_CTYPE=pt_BR.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=pt_BR.UTF-8        LC_COLLATE=pt_BR.UTF-8    
 [5] LC_MONETARY=pt_BR.UTF-8    LC_MESSAGES=pt_BR.UTF-8   
 [7] LC_PAPER=pt_BR.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=pt_BR.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] ExomeDepth_1.1.12

loaded via a namespace (and not attached):
 [1] matrixStats_0.55.0          lattice_0.20-38            
 [3] IRanges_2.20.1              Biostrings_2.54.0          
 [5] Rsamtools_2.2.1             GenomicAlignments_1.22.1   
 [7] bitops_1.0-6                grid_3.6.0                 
 [9] GenomeInfoDb_1.22.0         stats4_3.6.0               
[11] magrittr_1.5                zlibbioc_1.32.0            
[13] XVector_0.26.0              S4Vectors_0.24.1           
[15] Matrix_1.2-18               aod_1.3.1                  
[17] BiocParallel_1.20.0         tools_3.6.0                
[19] Biobase_2.46.0              RCurl_1.95-4.12            
[21] DelayedArray_0.12.1         parallel_3.6.0             
[23] compiler_3.6.0              BiocGenerics_0.32.0        
[25] GenomicRanges_1.38.0        SummarizedExperiment_1.16.0
[27] GenomeInfoDbData_1.2.2 
vplagnol commented 4 years ago

Yes so ExomeDepth has not been updated. You should see:

> packageVersion("ExomeDepth")
[1] ‘1.1.13’

Are you sure devtools::install_github("vplagnol/ExomeDepth") completed without errors?

SouzaBB commented 4 years ago

Did everything again, ExomeDepth has updated.

other attached packages: [1] ExomeDepth_1.1.13

Still having the same error:

Erro: RangedData objects are deprecated and the rownames setter for
  RangedData objects is now defunct. Please migrate your code to use
  GRanges or GRangesList objects instead. See IMPORTANT NOTE in
  ?RangedData

Além disso: Warning messages:

1:   RangedData objects are deprecated. Please migrate your code to use
  GRanges or GRangesList objects instead. See IMPORTANT NOTE in
  ?RangedData 
vplagnol commented 4 years ago

It's strange... I removed any occurrence of RangedData... Nothing is left in the code. I don't understand where that may be coming from.

SouzaBB commented 4 years ago

Is it working ok for you? Maybe the error comes from my input data!?

vplagnol commented 4 years ago

It works for me but with R 3.5. It is R 3.6 that makes the RangedData deprecated. So if you still see some RangedData somewhere, I must be doing something wrong... I just can't figure out where!

vplagnol commented 4 years ago

OK I installed R 3.6 and it works fine with version 1.13 of ExomeDepth. I suspect something is not right about your setup. My test is very basic:

library(ExomeDepth)
myres <- getBamCounts(bed.file = 'data/bedFiles/exons_hg19_small.bed', bam.files = 'data/small_exome.bam',
                         min.mapq = 20, read.width = 300, include.chr = FALSE, referenceFasta = 'data/hg19_nochr.fa')

but it works fine.

SouzaBB commented 4 years ago

Hi @vplagnol, Worked... I've found a problem with my syntax, now everything is fine! Thank you very much for your patience in solving the issue!

vplagnol commented 4 years ago

Ah OK. I wanted to submit version 1.13 to CRAN but unfortunately:

The submission server team is on vacation from Dec 20, 2019 to Jan 6, 2020
During this time the submission of packages is not possible.

It will have to wait until next year. Meanwhile, use the version on github...

 

SouzaBB commented 4 years ago

Ok, that's the version I'm using!

Thanks.

vplagnol commented 4 years ago

Last ranged objects gone in 1.1.15 (on its way to CRAN), so closing that issue.