search

vplan-fr / VPlan_FR

GNU General Public License v3.0
5 stars 0 forks source link

Allow not implemented schools #220

Closed SachsenspieltCoding closed 1 year ago

SachsenspieltCoding commented 1 year ago

Since I was asked to contribute, here I am. IMO it would be a good option to let the user add their own school with their student credentials. Maybe this could be some kind of experimental feature that warns the user: it can get buggy if you use untested schools.

ArtrenH commented 1 year ago

Actually, this is implemented. Students can submit schools that get sent to us for review for safety reasons

SachsenspieltCoding commented 1 year ago

But why do they need to be reviewed? I don't get it.

ArtrenH commented 1 year ago

In theory, schools hosted on stundenplan24.de don't need to be verified but because we need to restart our plan loader, this is our current way. We plan to automatically restart it after adding a school to the database. We already do check if a submitted school is valid and the credentials are correct.

SachsenspieltCoding commented 1 year ago

I totally understand. But from the user's point of view, it's a bit ugly to have to contact the developers to use a replacement schedule application.