Implement picture storage

[vpmalley]

Use Laravel features to implement file storage, reference it as Link and provide a public URL through this class

[vpmalley]

An existing picture can now be stored. Required: logged in user, existing picture stored in DB, and a CSRF token. The file will be stored locally.

[vpmalley]

Remaining:

• figure if there is any prerequisite regarding the CSRF token
• test

[Vallenain]

I tried a basic POST request on /api/0.1/pix/upload and it's not working at the moment (but it makes sense, your last comment was saying so). Anyway, would it be possible to have what's needed from the front part so I can implement my part ? Especially:

• Is the file sent in one time or chunk by chunk ?
• How do we associate an uploaded file to an object (to an article) ?

Thanks

[vpmalley]

The details of how to upload a picture are on the wiki page to use Postman. In short, a multipart request (form-data) with the picture_id (it must be created) and the picture_file should be sent. The user will need the right to write the image (not implemented yet).

So far, the response contains a json with the picture_id and a url that is actually just an internal path. In the future it will contain an actual url, that is what is left to finish this feature.

[vpmalley]

TODO: deletion of uploaded file

[vpmalley]

Done: the upload now returns the entire Picture object.

[vpmalley]

/!\ changing the endpoint I included the modification of the caption. Now the upload endpoint accepts 3 pair key/value:

• id
• caption
• file

[vpmalley]

Remaining

• [ ] return a public url (without simple ids) after upload is successful
• [ ] endpoint to delete uploaded file
• [ ] implement resource access control
• [ ] make tests pass

[Vallenain]

@vpmalley 404 Not Found when performing POST request on /api/0.1/upload/pix (funny thing, I can see the route in /routes so is that something on my side ?)

[vpmalley]

I think I know what's wrong: this API returns 404 when the picture (with the id you passed) does not exist. Did you use the new keys for the parameters? Now you should put the picture id in the form parameters with the id key (but I am not sure how it behaves when you forget the picture_id key)

[Vallenain]

Yes! That was it ! It should be a HTTP 400 to be closer to HTTP standards.

[vpmalley]

OK, I'll change that

[vpmalley]

I just fixed that by returning HTTP 400 for a missing picture id. I think the right fix should be to have an endpoint api/{version}/pictures/{pictureId}/upload, and return 404 if the picture is missing. To be done some day