search

vporton / django-payee

Accept (regular and subscription) payments in Internet (currently supports PayPal). Advanced support for subscription payments. https://github.com/vporton/django-debits/wiki
Other
2 stars 2 forks source link

Get rid of `gratis` #5

Open vporton opened 7 years ago

vporton commented 7 years ago

We should get rid of gratis in the SubscriptionItem model and instead test for price == 0.

vporton commented 7 years ago

Note that usually canceling of gratis state happens only through a purchase, while during purchase a new price is set, so old price (even if it would be nonzero) is ignored and so there is no need to store a nonzero price in the case if gratis flag is set.

The conclusion: We do not need both gratis boolean flag and price field.