search

vprover / vampire

The Vampire Theorem Prover
https://vprover.github.io/
Other
282 stars 49 forks source link

switch to C++17 #537

Closed MichaelRawson closed 5 months ago

MichaelRawson commented 5 months ago

It's been about three years since we switched to C++14 in #197. C++17 has things we would like, so let's switch.

This:

  1. Switches the compiler flags appropriately.
  2. Fixes resulting warnings (std::result_of deprecated in favour of std::invoke_result)
  3. Goes through the code fixing all "when we have C++17" comments - except for one in Hash.hpp @joe-hauns - I couldn't figure out what you meant, maybe you remember?
  4. Replaces a few Lib::System functions that are now trivial in C++17.

I've asked anyone whose code I've touched to review. But anyone is welcome to review!

MichaelRawson commented 5 months ago

Thanks all for quick reviews! Merging.