search

vprover / vampire

The Vampire Theorem Prover
https://vprover.github.io/
Other
282 stars 49 forks source link

ERD as simplifier #581

Closed quickbeam123 closed 1 month ago

quickbeam123 commented 1 month ago

I hacked this up during Uwe's talk at IJCAR.

Not sure if we want it, but it's a small change and seems to help (for UNS) a tiny bit:

Sort by UNS
7567 ['problemsSTD_rel_erds7706_dis5_sims-off_i5000.pkl']
7577 ['problemsSTD_rel_erds7706_dis5_i5000.pkl']
7585 ['problemsSTD_rel_erds7706_dis5_erd-simplif_i5000.pkl']

(coincidentally, the change improvement is in a similar ballpark to what we lose if we turn off simultaneous superposition).

For SAT, we consider erd=simplif an incomplete strategy, so we get:

Sort by SAT
517 ['problemsSTD_rel_erds7706_dis5_erd-simplif_i5000.pkl']
986 ['problemsSTD_rel_erds7706_dis5_i5000.pkl']
986 ['problemsSTD_rel_erds7706_dis5_sims-off_i5000.pkl']
easychair commented 1 month ago

Hi, I don't think we need this rule. We made experiments in the past - it does not help to solve new problems.

Uwe's talk was about "let's apply the standard construction and see what we obtain" - anybody understanding the construction would come up with the same results in 30 minutes.

Cheers, Andrei

On Fri, 19 Jul 2024 at 08:03, Martin Suda @.***> wrote:

I hacked this up during Uwe's talk at IJCAR.

Not sure if we want it, but it's a small change and seems to help (for UNS) a tiny bit:

Sort by UNS 7567 ['problemsSTD_rel_erds7706_dis5_sims-off_i5000.pkl'] 7577 ['problemsSTD_rel_erds7706_dis5_i5000.pkl'] 7585 ['problemsSTD_rel_erds7706_dis5_erd-simplif_i5000.pkl']

(coincidentally, the change improvement is in a similar ballpark to what we lose if we turn off simultaneous superposition).

For SAT, we consider erd=simplif an incomplete strategy, so we get:

Sort by SAT 517 ['problemsSTD_rel_erds7706_dis5_erd-simplif_i5000.pkl'] 986 ['problemsSTD_rel_erds7706_dis5_i5000.pkl'] 986 ['problemsSTD_rel_erds7706_dis5_sims-off_i5000.pkl']

You can view, comment on, or merge this pull request online at:

https://github.com/vprover/vampire/pull/581 Commit Summary

File Changes

(9 files https://github.com/vprover/vampire/pull/581/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/vprover/vampire/pull/581, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVY4BOSN3YV6OJEMCNRFHTZNC25XAVCNFSM6AAAAABLEAPDS2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTQMRRG4ZTCNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

quickbeam123 commented 1 month ago

Fair point, Andrei! Let's put this to ice.