Closed dependabot[bot] closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.7%. Comparing base (
b1c109e
) to head (fe61b1a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dependabot rebase
The doc examples in this PR are still failing because the expected output is 4
but doctest calculates it as np.float64(4)
. Why don't we see similar failures in pytest workflows?
The failures are due to newer print options in numpy. So, it's understandable they don't appear as failures in pytest workflows as we don't use print
to compare the calculated and expected outputs.
https://numpy.org/neps/nep-0051-scalar-representation.html
My suggestion is to change the expected outputs in docstring examples to be consistent with the new print options. WDYT @vprusso ?
We could set the print option to use an earlier version of numpy. But this does not make sense as a user will see the newer scalar representations pop up if they print something locally.
This PR is very close. The only failure that we have to deal with is below:
File "autoapi/state_opt/symmetric_extension_hierarchy/index.rst", line 164, in default
Failed example:
np.around(symmetric_extension_hierarchy(states=states, probs=None, level=2), decimals=2)
Exception raised:
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/doctest.py", line 1355, in __run
exec(compile(example.source, filename, "single",
File "<doctest default[12]>", line 1, in <module>
np.around(symmetric_extension_hierarchy(states=states, probs=None, level=2), decimals=2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/toqito/toqito/toqito/state_opt/symmetric_extension_hierarchy.py", line 197, in symmetric_extension_hierarchy
sol_default = problem.solve()
^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/problems/problem.py", line 503, in solve
return solve_func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/problems/problem.py", line 1073, in _solve
data, solving_chain, inverse_data = self.get_problem_data(
^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/problems/problem.py", line 696, in get_problem_data
data, inverse_data = solving_chain.apply(self, verbose)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/reductions/chain.py", line 76, in apply
problem, inv = r.apply(problem)
^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/reductions/solvers/conic_solvers/scs_conif.py", line 214, in apply
return super(SCS, self).apply(problem)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/reductions/solvers/conic_solvers/conic_solver.py", line 355, in apply
problem, data, inv_data = self._prepare_data_and_inv_data(problem)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/reductions/solvers/conic_solvers/conic_solver.py", line 332, in _prepare_data_and_inv_data
problem = self.format_constraints(problem, self.EXP_CONE_ORDER)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/cvxpy/reductions/solvers/conic_solvers/conic_solver.py", line 264, in format_constraints
unspecified, remainder = divmod(problem.A.shape[0] *
^^^^^^^^^^^^^^^^^^^^^^^^^^^
OverflowError: Python integer 2313073664 out of bounds for int32
https://github.com/vprusso/toqito/actions/runs/9933035887/job/27435221058#step:5:3171
I think it's better to disable this for now and create a separate issue for the error. It will take me a while to dig into the source of the raised error.
Looks great, @purva-thakre. Once the merge conflict with the poetry.lock
file is resolved, I think it should be good to go!
@dependabot rebase
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!
If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate
.
Will check on what the installation issues mean later.
https://github.com/vprusso/toqito/actions/runs/9939417469/job/27454339453?pr=656#step:4:283
Closing this for a new PR. I can't figure out the source of the build error.
I don't see similar errors locally. 🤷🏾♀️
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore
condition with the desired update_types
to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
We are already doing what the top voted answer recommends.
There are two different errors. cvxopt and pep 517 related SO links are above.
The other one is error: command '/usr/bin/gcc' failed with exit code 1
: https://stackoverflow.com/questions/19955775/error-command-gcc-failed-with-exit-status-1-on-centos
Why do we see these failures for python 3.12 on ubuntu and macos only?
Not the same error we are getting but similar pep517 messages were fixed by downgrading poetry.
https://github.com/vprusso/toqito/pull/656/commits/307e79830bcb7e595f496b3ade99cdb63daf9184 might have worked except that cvxopt is being installed as a dependency again through poetry install
.
Need to create a better dependency group.
A newer version of numpy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.
@dependabot recreate
Superseded by #752.
Fixes #618
Updates the requirements on numpy to permit the latest version.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
1d49c7f
Merge pull request #26698 from charris/prepare-2.0.02103511
DOC: Remove duplicate in author list.db8030e
BUG: Change cibuildwheel version [wheel build]1a68264
REL: Prepare for the NumPy 2.0.0 release [wheel build]c8665ba
Merge pull request #26696 from charris/backport-26582103f4dd
Merge pull request #26697 from charris/backport-25963c193dcd
Merge pull request #26695 from charris/backport-266678fa8191
BUG: Fix bug in numpy.pad() (#25963)ece3559
BUG: weighted nanpercentile, nanquantile and multi-dim q (#26582)b31e195
BUG: Adds asanyarray to start of linalg.cross (#26667)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show