search

vpusher / game-card

playing game card element based on ES6 and Polymer 2.0
MIT License
41 stars 11 forks source link

Setting rank and symbol after element creation is not possible #2

Closed alejandro-du closed 7 years ago

alejandro-du commented 7 years ago

This won't update the state correctly:

<game-card id="the-card" unrevealed></game-card>
<script>
    var card = document.getElementById("the-card");
    card.set("symbol", "♥");
    card.set("rank", "k");
</script>
alejandro-du commented 7 years ago

I created a pull request that fixes the issue. Hope you can merge it and publish a new version soon. I'd like to showcase this component in the release of Vaadin 8 :)

vpusher commented 7 years ago

Great ! I will check and release it asap.

vpusher commented 7 years ago

@alejandro-du Released in version 1.0.3. Thanks a lot !

alejandro-du commented 7 years ago

Thank you for the component!

vpusher commented 7 years ago

@alejandro-du Don't hesitate to link your work when you are done ;)

alejandro-du commented 7 years ago

It's going to be featured in a short video... I'll let you know once I publish it ;)

alejandro-du commented 7 years ago

The video is ready: https://www.youtube.com/watch?v=aIbbS_o3eZs And your web component is also featured here: https://vaadin.com/framework/whatsnew Cheers!

vpusher commented 7 years ago

@alejandro-du Great 👍