Closed 0dminnimda closed 3 years ago
@BruceSherwood can you run workflow and review changes please?
@0dminnimda -- I can take a look at this later today. I've approved the workflow (really wish that github didn't require that)
I can take a look at this later today
Would be great!
really wish that github didn't require that
Well, there are reasons for this, like make it harder for spammers to send bad code to ci and effectively slow it down for this repo.
But i agree, it's a bit frustrating task to approve those workflows
awaiting for workflow run and merge
oh wait, i think we also should update the docs. tho as i see the docs are not in this repo. so this pr can be merged
One last question -- how would you like to be listed in the list of contributors at https://github.com/vpython/vpython-jupyter/blob/master/CONTRIBUTORS.md ?
under my username - 0dminnimda
Excellent, thanks!
*args
TypeError
instead ofAttributeError
".png" in "name.png.jpg"
will returnTrue
, instead we need to check the last four charactersinclude_labels
is now set to"T"
explicitly viacapture_labels=True
:
, add whitespaces around+