vpython / vpython-jupyter

3D visualization made easy
MIT License
138 stars 64 forks source link

Improve the `capture` implementation and fix its bugs #165

Closed 0dminnimda closed 3 years ago

0dminnimda commented 3 years ago
0dminnimda commented 3 years ago

@BruceSherwood can you run workflow and review changes please?

mwcraig commented 3 years ago

@0dminnimda -- I can take a look at this later today. I've approved the workflow (really wish that github didn't require that)

0dminnimda commented 3 years ago

I can take a look at this later today

Would be great!

0dminnimda commented 3 years ago

really wish that github didn't require that

Well, there are reasons for this, like make it harder for spammers to send bad code to ci and effectively slow it down for this repo.

But i agree, it's a bit frustrating task to approve those workflows

0dminnimda commented 3 years ago

awaiting for workflow run and merge

0dminnimda commented 3 years ago

oh wait, i think we also should update the docs. tho as i see the docs are not in this repo. so this pr can be merged

0dminnimda commented 3 years ago

One last question -- how would you like to be listed in the list of contributors at https://github.com/vpython/vpython-jupyter/blob/master/CONTRIBUTORS.md ?

under my username - 0dminnimda

mwcraig commented 3 years ago

Excellent, thanks!