vr-components / css-vr-boilerplate

Getting started with VR CSS
2 stars 1 forks source link

Eliminate mouse look rolling #3

Closed jcarpenter closed 9 years ago

jcarpenter commented 9 years ago

Mouse look should only effect pitch and yaw on the current forward vector. It should not effect roll. As demonstrated in this Three.js pointer lock example: http://threejs.org/examples/misc_controls_pointerlock.html

Currently mouse look effects the pitch of the camera if the mouse is in the center of the screen, but effects roll as the mouse moves towards the left and right sides.

dmarcos commented 9 years ago

Gimbal lock issues :S I made this same mistake like a million times already. See if I learn from this one.

This should be fixed now.

https://github.com/vr-components/css-vr-boilerplate/commit/94155f636c8ad499465ac47bfdbcda46ba596789

@jcarpenter Can you verify it it's working for you now?

dmarcos commented 9 years ago

@jcarpenter if you can confirm that this is working for you i'll close the issue

jcarpenter commented 9 years ago

Resolved!