search

vrajkumar128 / Colmar-Academy

0 stars 0 forks source link

HTML #2

Open Axkaban opened 6 years ago

Axkaban commented 6 years ago

Thank you for the comments!

https://github.com/vrrajkum/Colmar-Academy/blob/master/index.html#L58

https://github.com/vrrajkum/Colmar-Academy/blob/master/index.html#L72

https://github.com/vrrajkum/Colmar-Academy/blob/master/index.html#L182

I always like to point out how important they are, make it a habit, you’re doing great!

As a comment, some people like to keep header and footer outside of the body, in general I am not sure which one is standard, but personally I like to keep everything inside of body.

A last complement is on indentation and class vs id, well carried, Also, role? I have only seeing it once or twice, what made you assign roles to your divs?(just curious)

vrajkumar128 commented 6 years ago

@Axkaban Most professional websites that I've seen keep header and footer inside the body, so I think that's the standard. This makes sense considering that they are just HTML5 semantic elements designed to replace <div class="header"> and <div class="footer"> elements that were often used in previous versions of HTML.

With respect to role, the Codecademy course that this project is for has a lesson on ARIA and suggests utilizing it to differentiate us from other web developers who may not be versed in ARIA.

Axkaban commented 6 years ago

Sounds great! Plus now you have showed me about ARIA! Which is fantastic! Thank you!