Being a Drupal developer, this extension is really valuable for me to adhere to Drupal coding standards.
I found some misbehaviors and I'd like to suggest some fixes.
Menu action Tools->Scan for violations did nothing (and exits without an error) if clicked with one (or more) file selected.
It took some time for me to understand it (I thought it also worked with a single file selected).
After looking at the plugin source code I understood how it works (and documentation is not so clear), so I suggest to (in order of preference):
) make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise
OR
) add an error message to warn the user that this action should be only run on a folder
OR
*) change its caption to "Scan folder for violations"
I found another misbehavior on the project files context menu.
Item "Check for violations" is enabled both for single and multiple selection BUT its action only runs if a single file is selected (and exits silently if more than one file is selected), so I suggest to:
) let it work like the first suggestion above: make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise
OR
) let it work with more than one file selected
OR
*) disable it when a folder or more than one file is selected
I looked at source code, but I'm not an experienced NetBeans Plugin developer so I only changed item caption to avoid me falling again into this error.
Being a Drupal developer, this extension is really valuable for me to adhere to Drupal coding standards. I found some misbehaviors and I'd like to suggest some fixes.
Menu action Tools->Scan for violations did nothing (and exits without an error) if clicked with one (or more) file selected. It took some time for me to understand it (I thought it also worked with a single file selected). After looking at the plugin source code I understood how it works (and documentation is not so clear), so I suggest to (in order of preference): ) make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise OR ) add an error message to warn the user that this action should be only run on a folder OR *) change its caption to "Scan folder for violations"
I found another misbehavior on the project files context menu. Item "Check for violations" is enabled both for single and multiple selection BUT its action only runs if a single file is selected (and exits silently if more than one file is selected), so I suggest to: ) let it work like the first suggestion above: make it visible for both files and folder selection and run a "single file" check when a file is selected (like the project context menu item) and a "folder scan" otherwise OR ) let it work with more than one file selected OR *) disable it when a folder or more than one file is selected
I looked at source code, but I'm not an experienced NetBeans Plugin developer so I only changed item caption to avoid me falling again into this error.
Best regards Claudio