Plane-aligned plant models get bad shading from adjacent occluders

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric

GNU Lesser General Public License v3.0

422 stars 40 forks source link

Plane-aligned plant models get bad shading from adjacent occluders #11

Closed grondag closed 5 years ago

grondag commented 5 years ago

https://gfycat.com/CaringInfatuatedGibbon

grondag commented 5 years ago

Stangeness: seagrass model is reporting it has amibent occlusion even tho model JSON says no. Could something be changing it?

grondag commented 5 years ago

This is not exactly fixed so much as broken in a more pleasing way. A correct fix will need to wait for a more sophisticated lighting model. The current, vanilla-based model doesn't actually use information about the current block's lighting value - only neighbors, which means interior-lit quad suffer from anisotropy.

cc @InsomniaKitten