vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
422 stars 40 forks source link

Item entities with glowing effect invisible #183

Closed UltraBlackLinux closed 2 years ago

UltraBlackLinux commented 3 years ago

Hey, there, I have 2 topics with me:

  1. On Hypixel skyblock, all dropped items get the glowing effect, but canvas renderer, makes them invisible, here a side-to-side comparison with and without canvas, to show my problem: Screenshot_20210101_201209

  2. Please make a support discord, where you can quickly ask for help, without having to create an issue, it would really help (me) out!

Thanks!

grondag commented 3 years ago

Thank you for the issue report.

There is already a discord for my mods: https://discord.gg/7NaqR2e. I've added a link to the read me.

spiralhalo commented 2 years ago

This should be fixed by https://github.com/vram-guild/canvas/commit/3cd5d5e8a3e5ccf05ea61c2bb528483863da0502 - https://github.com/vram-guild/canvas/commit/0c0c275d11b5372dcf82f3e166036b6fd27c3be5

But grondag hasn't reviewed the code yet. Will close if the changes stay by the next release.

supsm commented 2 years ago

cannot reproduce in latest canvas, looks like the fix was kept @spiralhalo