search

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
419 stars 40 forks source link

Canvas MaterialMaps for Crops #200

Open Disketaa opened 3 years ago

Disketaa commented 3 years ago

It's weird, but low-foliage on crop-blocks also working on seed items. ezgif com-gif-maker image

spiralhalo commented 3 years ago

It was considered working as intended, as Canvas default pack itself has to include empty material map to override the waving items (see https://github.com/grondag/canvas/commit/408c05206b4151f383e82cce929f2d975d22633f) but I do agree that it is weird.

spiralhalo commented 3 years ago

Quote from Grondag on his discord server:

I think it's because item models inherit material maps from blocks by default, because that's what a mod will usually want and is less work most of the time. But if you have an item like seeds where this is undesirable then you need to do the extra (and un-obvious) step of creating an item material map.

I'm open to ideas on how to make this nicer. Maybe material maps for blocks should accept a "transitive" property to enable/disable this behavior.

I think the issue here is that block items should have the same material as the block itself most of the time. Seeds are sort of an exception to this rule because they look so different from the block they represent, or most people expect them to be a completely separate item but internally they are block items.

As Grondag said, we're open to ideas but it's technically working as intended therefore I'm labeling this an enhancement.