vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
422 stars 40 forks source link

A few custom model parts don't light except with held items #333

Closed Variadicism closed 2 years ago

Variadicism commented 3 years ago

Hello! I use quite a few resource pack assets that have custom models. Unfortunately, a couple of them seem to encounter an issue with Canvas that causes them to render parts of them as if they are in complete darkness.

However, one exception to this is that when I hold a light-emitting block or item such as glowstone or a torch, the light correctly lights these unlit model parts.

This is best exhibited by the "short grass" that sits atop the grass block models in the Fancy resource pack.

Here is what I see in this resource pack while running Canvas renderer: 2021-10-05_21 43 00

Here is what happens when I hold glowstone: 2021-10-05_21 43 09

I love the short grass model from the Fancy resource pack; I would love a fix to this so that I could use it again with this renderer!

P.S.: I only tried Canvas for the first time recently and I have never had a framerate like this! For me, it was not only so much higher than OptiFine, but also so much higher than Sodium... and Sodium breaks so many more resource pack features and has far fewer configuration options! I can't thank you enough for making this!

spiralhalo commented 2 years ago

Happens also with blocky custom models (stalactite from Patrix's resourcepack). Light smoothing level has no effect.

image

grondag commented 2 years ago

Should hopefully be improved as part of https://github.com/vram-guild/frex/issues/3