Broken transparency in materials that (?) write to solid framebuffer as well as inventory

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric

GNU Lesser General Public License v3.0

416 stars 40 forks source link

Broken transparency in materials that (?) write to solid framebuffer as well as inventory #394

Closed ambrosia13 closed 1 year ago

ambrosia13 commented 1 year ago

System Information

Minecraft Version: 1.19.2
Canvas Version: 2480
Operating System: Windows
Graphics Card: RTX 3060

Other mods and versions installed

fabric-api-0.62.0+1.19.2
canvas-fabric-mc119-1.0.2480

How you triggered the behavior

start minecraft
log into singleplayer world
look at any cutout item, in inventory or in world

What you expected would happen

Transparency/cutout material works as intended

What actually happened

Material is black where it is supposed to be discarded
Only an issue in 1.19.2, I can confirm that this does not happen on my 1.19.0 profile

Logs and screenshots

latest.log

supsm commented 1 year ago

issue can be reproduced with 3050 and 3070 Ti (the collection is almost complete :tinypotato:)

ambrosia13 commented 1 year ago

Version 2477 works as expected

supsm commented 1 year ago

Also, some "item backgrounds" are green or white instead of black

supsm commented 1 year ago

hmm... this is only made worse by release 2487, which straight up crashes when a chest item is being rendered.
To reproduce:

open inventory in creative OR
/give yourself a chest with an empty hotbar (I haven't tested with other items yet)

crash reports: crash-2022-10-13_19.32.26-client.txt crash-2022-10-13_19.30.20-client.txt

spiralhalo commented 1 year ago

hmm... this is only made worse by release 2487, which straight up crashes when a chest item is being rendered. To reproduce:
* open inventory in creative
  OR

* /give yourself a chest with an empty hotbar (I haven't tested with other items yet)
crash reports: crash-2022-10-13_19.32.26-client.txt crash-2022-10-13_19.30.20-client.txt

Should be fixed in https://github.com/vram-guild/canvas/commit/957b8cf10961b37345579d6d5ecd59358d99920e

Original issue was fixed in https://github.com/vram-guild/frex/commit/09d4e5196dd9d05ba3d3aca91cd78562ed59a149