search

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
425 stars 40 forks source link

enable `GL_TEXTURE_CUBE_MAP_SEAMLESS` ... #403

Closed fewizz closed 1 year ago

fewizz commented 1 year ago

... globally, at the Minecraft class constructor tail. Fixes cubemap texture linear filter. Change glFramebufferTextureLayer call to glFramebufferTexture2D for cubemaps.

ambrosia13 commented 1 year ago

I've used this quite a bit for Forget-me-not, especially for cube-mip-maps. It works as intended for me.

Under the standard filtering rules for cubemaps, filtering does not work across faces of the cubemap. This results in a seam across the faces of a cubemap. This was a hardware limitation in the past, but modern hardware is capable of interpolating across a cube face boundary.