search

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
418 stars 40 forks source link

Flywheel Compat #406

Closed AlphaMode closed 1 year ago

AlphaMode commented 1 year ago

This PR fixes issues with Flywheel Compat allow canvas to be used with the Create mod. This is pretty much a copy of spiralhalo Flywheel branch, but it adds support for the CrumblingRenderer, and is based off the 1.19.2 branch and not 1.18.2

I'm not sure why the compat was never finished, if someone else is working on it or this has a technical problem feel free to just close this.

spiralhalo commented 1 year ago

If it's based on the flywheel-compat branch, you should extend from that branch so the history is visible. Helps me determine what's added and needs to be tested.

As for why it was never finished, Flywheel dev(s) were saying that they are rewriting (may not be the exact wording) their API at the time of the compat branch development. Afterwards, I didn't end up keeping up with their dev cycle to ensure the compat is still working or even required anymore (I guess it still is).

Another reason is I don't play with Create extensively to deem the compat "good enough".

Please forgive me in advance if you decided to address the problems raised but I didn't notice your updated PR as the attention I could give to MC modding is reduced nowadays.