search

vram-guild / canvas

Shader-Based Minecraft Renderer for Fabric
GNU Lesser General Public License v3.0
418 stars 40 forks source link

Fix: `FabulousFrameBuffer` should extend `RenderTarget`, not `MainTarget` #425

Closed fewizz closed 1 year ago

fewizz commented 1 year ago

Fixes Framebuffer object leakage: previously MainTarget's constructor called createFrameBuffer() which created framebufer object and assigned resulting id to frameBufferId, but then it's value was overwritten in the FabulousFrameBuffer's constructor.

spiralhalo commented 1 year ago

This seems serious. Is this serious?

Did this basically create a few (5?) unused framebuffers before the fix?

Can this be backported to previous versions?

fewizz commented 1 year ago
  1. Yes.
  2. Yes.
  3. Yes.
spiralhalo commented 1 year ago

Nice!